Author Topic: Search not working  (Read 3270 times)

0 Members and 1 Guest are viewing this topic.

Offline sphinx_spb

  • Member
  • ***
  • Posts: 47
  • Karma: +10/-3
Search not working
« on: 03 July, 2007, 06:59:11 »
I found that if username contain the ? symbol, the search for this user not working. Profile not matters, even master.
Is this a bug?

And one question. In profile manager, we have a checkbox "Don't check IP in DC commands", currently unchecked for all profiles. What is it for?

« Last Edit: 03 July, 2007, 07:16:57 by sphinx_spb »

PtokaX forum

Search not working
« on: 03 July, 2007, 06:59:11 »

Offline PPK

  • Administrator
  • Emperor
  • *****
  • Posts: 1 481
  • Karma: +209/-22
  • PtokaX developer
Re: Search not working
« Reply #1 on: 03 July, 2007, 07:25:29 »
Checked and here is bug, bug in DC++ (and maybe all his mods). Active search with ? working, but in passive clients return search results with wrong nick...
Code: [Select]
$Search Hub:koblizek? F?T?0?1?.mp3|
$SR bruselak14 Downloads\01 - By The Way.Mp33483648 56/75TTH:XFSIBUAVHRVSKPI23GQ2ECWBT6VTNSXVNUJUAJY (213.235.184.138:4861)koblizek??˘|

//EDIT
? is not only problematic character for DC++ 0.4033 and higher. Direct Connect, DC++ 0.4032 and older working ok and user with ? receiving search results from them.
« Last Edit: 03 July, 2007, 09:25:52 by PPK »
"Most of you are familiar with the virtues of a programmer. There are three, of course: laziness, impatience, and hubris." - Larry Wall

Offline bastya_elvtars

  • Forum God
  • ****
  • Posts: 3 745
  • Karma: +173/-7
  • The rock n' roll doctor
    • The FreshStuff3 Site
Re: Search not working
« Reply #2 on: 03 July, 2007, 15:02:32 »
Unicode, huh? ;D
Everything could have been anything else and it would have just as much meaning.

Offline PPK

  • Administrator
  • Emperor
  • *****
  • Posts: 1 481
  • Karma: +209/-22
  • PtokaX developer
Re: Search not working
« Reply #3 on: 03 July, 2007, 16:05:26 »
Yes, DC++ converting received data to utf-8 and sending nick in it back in search reply ;D
"Most of you are familiar with the virtues of a programmer. There are three, of course: laziness, impatience, and hubris." - Larry Wall

Offline bastya_elvtars

  • Forum God
  • ****
  • Posts: 3 745
  • Karma: +173/-7
  • The rock n' roll doctor
    • The FreshStuff3 Site
Re: Search not working
« Reply #4 on: 03 July, 2007, 16:27:08 »
Cool. So theclients prior to 0.4033 are unlikely to get proper search replies if there are funny characters in the results' owners' nicks. This would not be bad, if 0.6xx DC++ versions were actualy usable. :P
Everything could have been anything else and it would have just as much meaning.

Offline sphinx_spb

  • Member
  • ***
  • Posts: 47
  • Karma: +10/-3
Re: Search not working
« Reply #5 on: 03 July, 2007, 16:38:38 »
Well, actually I use one of the last ApexDC mods, I'l tell this bug to its developers...
Thanks for your reply, PPK!

Offline PPK

  • Administrator
  • Emperor
  • *****
  • Posts: 1 481
  • Karma: +209/-22
  • PtokaX developer
Re: Search not working
« Reply #6 on: 04 July, 2007, 04:56:34 »
So theclients prior to 0.4033 are unlikely to get proper search replies if there are funny characters in the results' owners' nicks.
They get search results, but only from non-DC++ based clients and DC++/DC++ mods with core before 0.4033.
"Most of you are familiar with the virtues of a programmer. There are three, of course: laziness, impatience, and hubris." - Larry Wall

Offline bastya_elvtars

  • Forum God
  • ****
  • Posts: 3 745
  • Karma: +173/-7
  • The rock n' roll doctor
    • The FreshStuff3 Site
Re: Search not working
« Reply #7 on: 12 July, 2007, 04:24:47 »
Not a bug. Locking.
Everything could have been anything else and it would have just as much meaning.

PtokaX forum

Re: Search not working
« Reply #7 on: 12 July, 2007, 04:24:47 »